-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch new untracked and unignored files #3875
Conversation
Can we also adjust
|
Signed-off-by: Avi Deitcher <avi@deitcher.net>
bce0b49
to
2325516
Compare
Good idea. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
With such changes we will be able to completely get rid of force
flag during local development, since now linuxkit (and user) will see that there are changes in source tree regardless of git add
command which may come later.
Let's make FORCE_BUILD flag optional and rely on hash provided by linuxkit on changes (linuxkit/linuxkit#3875). With no flag provided linuxkit will check that image published, if not, will build it. This way we can avoid building of dependencies as well. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
With enforced checking from linuxkit (linuxkit/linuxkit#3875) we must be more accurate with generated files and add them to gitignore Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
With enforced checking from linuxkit (linuxkit/linuxkit#3875) we must be more accurate with generated files and add them to gitignore Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
Let's make FORCE_BUILD flag optional and rely on hash provided by linuxkit on changes (linuxkit/linuxkit#3875). With no flag provided linuxkit will check that image published, if not, will build it. This way we can avoid building of dependencies as well. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
With enforced checking from linuxkit (linuxkit/linuxkit#3875) we must be more accurate with generated files and add them to gitignore Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit bcbbfaa)
Let's make FORCE_BUILD flag optional and rely on hash provided by linuxkit on changes (linuxkit/linuxkit#3875). With no flag provided linuxkit will check that image published, if not, will build it. This way we can avoid building of dependencies as well. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
With enforced checking from linuxkit (linuxkit/linuxkit#3875) we must be more accurate with generated files and add them to gitignore Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit bcbbfaa)
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
pkg show-tag
reports if a directory tree is dirty, but it misses new untracked files. If a file is in the directory, and is not tracked and also is not in.gitignore
, we should treat that is dirty.- How I did it
Added
ls-files
with appropriate options.- How to verify it
I tested it on various scenarios:
gitignore
- ignores it- Description for the changelog
show-tag
treats untracked and unignored files as a dirty package.