Propagate manifest option into push

[giggsoff]

We have distinct manifest option which is not used. Let's implement different behavior.

Signed-off-by: Petr Fedchenkov giggsoff@gmail.com

[deitch]

I don't get this. We always push a multi-arch index with our pushes. Why do we need an option to enable it?

[giggsoff]

It is enabled by default (at least for push). I want to implement the way to disable it.

[giggsoff]

Actually I can see errors trying to push image into GH container registry:

/home/runner/work/eve/eve/build-tools/bin/linuxkit -v pkg push --org ghcr.io/giggsoff   --release snapshot --docker --platforms linux/riscv64,linux/amd64 -manifest=false -build-yml build.yml pkg/mkimage-iso-efi
Building and pushing "ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978"
checking for ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978 in local cache...
found ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978 in local cache, skipping build
found ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978 in local cache, skipping build
Loaded image: ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978-riscv64
Loaded image: ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978-amd64
Tagging ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978-amd64 as ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978
Pushing ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978
ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978 index already available on remote registry, skipping push
Pushing ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot
existing manifest: sha256:5a93401a18ebe0da89f1d82ae791a514339defd9b65dc0c8ce8d77d3f43ea838
existing manifest: sha256:c705f1070e51bdfb4412ce1a292bb205d1508f20ce6faa90650231723e0af7a7
ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot: digest: sha256:be63ae9c7ca0b38ad4d0ba152d1a0faa476a1472e154fee247b9db7b93c612f9 size: 1115
Pushed index ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot
ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-riscv64: digest: sha256:5a93401a18ebe0da89f1d82ae791a514339defd9b65dc0c8ce8d77d3f43ea838 size: 708
ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-amd64: digest: sha256:c705f1070e51bdfb4412ce1a292bb205d1508f20ce6faa90650231723e0af7a7 size: 708
Pushing index based on all arch-specific images in registry ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot
Retrieving digests of member images
trying next host
time="2022-11-15T14:36:38Z" level=warning msg="Couldn't access image '\"ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-amd64\"'. Skipping due to 'ignore missing' configuration."
trying next host
time="2022-11-15T14:36:38Z" level=warning msg="Couldn't access image '\"ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-arm64\"'. Skipping due to 'ignore missing' configuration."
trying next host
time="2022-11-15T14:36:38Z" level=warning msg="Couldn't access image '\"ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-s390x\"'. Skipping due to 'ignore missing' configuration."
trying next host
time="2022-11-15T14:36:38Z" level=warning msg="Couldn't access image '\"ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-riscv64\"'. Skipping due to 'ignore missing' configuration."
trying next host
time="2022-11-15T14:36:38Z" level=warning msg="Couldn't access image '\"ghcr.io/giggsoff/eve-mkimage-iso-efi:snapshot-ppc64le\"'. Skipping due to 'ignore missing' configuration."
Error building and pushing "ghcr.io/giggsoff/eve-mkimage-iso-efi:bb1ed2807d4516c95cf5679049498bc7fdf40978": all entries were skipped due to missing source image references; no manifest list to push

And as you can see I set -manifest=false, but it did not change behavior, which is not expected. And I want to fix it in the PR.

[deitch]

It is enabled by default (at least for push). I want to implement the way to disable it.

Makes sense. Approved.

[deitch]

I will hold off on merge until you say the above is fixed.

[giggsoff]

I will hold off on merge until you say the above is fixed.

It is fixed, I put the log without the changes from the PR. With changes and manifest flag explicitly set to false I not go to Retrieving digests of member images... and ends with no errors.