switch from flags to cobra #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
cobra
branch
11 times, most recently
from
60bb619
to
b6e0643
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
|
Ah, lovely, CI finally green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
Replaced all of our custom flag handling with spf13/cobra
Provides much greater simplicity, reduces the need to handle things like help, number of arguments, etc.,
makes it easier to add features, aliases built in.
It also gives us things like persistent flags, so we can set cache-dir once, and verbose/quiet once/
- How I did it
Slowly and painfully
- How to verify it
CI
- Description for the changelog
Use modern flag libraries