fix alpine base update docs #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
rn
reviewed
Dec 29, 2022
| @@ -130,7 +130,7 @@ following which is an explanation of each one. | |||
| ```sh | |||
| # Update tools packages | |||
| cd $LK_ROOT/tools | |||
| $LK_ROOT/scripts/update-component-sha.sh --pkg $LK_ROOT/tools/alpine | |||
| $LK_ROOT/scripts/update-component-sha.sh --image $LK_ALPINE | |||
There was a problem hiding this comment.
what's the reason for this change? Does update-component-sha.sh no longer take the --pkg option?
There was a problem hiding this comment.
It does, but tools/alpine does not have a build.yml. To be fair, I have no idea how it worked before, but if this works, and we already are storing the LK_ALPINE var, might as well use it.
rn
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
Fixed a few misleading lines on the alpine base update doc
- How I did it
markdown
- How to verify it
Read it
- Description for the changelog
update docs