ensure push when already found image locally #3899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
Fixed a bug. See this action which should have pushed everything out and skipped everything.
The way
lkt pkg push
works is, it checks before pushing if there is anything to push. The logic for that says, "if I built something, try and push it; if not, look in local cache and then, if found, try and push it."When you
put pkg push --nobuild
, it explicitly does not build. But it also skips checking the cache. This means that--nobuild
actually means "do not build or push", when you really meant, "do not build, but if something already is in the cache, go ahead and push it."This fixes it so that the meaning is as expected.
- How I did it
Changes to
pkglib/build.go
- How to verify it
CI
- Description for the changelog
Fix
push --nobuild