Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure push when already found image locally #3899

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Jan 16, 2023

Signed-off-by: Avi Deitcher avi@deitcher.net

- What I did

Fixed a bug. See this action which should have pushed everything out and skipped everything.

The way lkt pkg push works is, it checks before pushing if there is anything to push. The logic for that says, "if I built something, try and push it; if not, look in local cache and then, if found, try and push it."

When you put pkg push --nobuild, it explicitly does not build. But it also skips checking the cache. This means that --nobuild actually means "do not build or push", when you really meant, "do not build, but if something already is in the cache, go ahead and push it."

This fixes it so that the meaning is as expected.

- How I did it

Changes to pkglib/build.go

- How to verify it

CI

- Description for the changelog

Fix push --nobuild

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch merged commit 6d95833 into linuxkit:master Jan 19, 2023
@deitch deitch deleted the push-without-build branch January 19, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant