Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-diskfs to latest #3902

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Bump go-diskfs to latest #3902

merged 1 commit into from
Jan 23, 2023

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Jan 23, 2023

- What I did

Bump go-diskfs in the metadata.
Fix the provider_cdrom to use the new Open method of diskfs

- How I did it

go get -u github.com/diskfs/go-diskfs@master && go mod vendor

Crazy I know, sometimes my genius… it's almost frightening :p

- How to verify it

Run metadata in the background with the full list of providers so the block devices are opened to get the size, then try to do something on those block devices, like create a new partition table. It will complain that the kernel cannot be informed of the changes to the block device due it being in use by something else.
Problem was mainly that if you run the metadata will the full list of providers and no metadata, it will take a while for all those providers to time out. So while the metadata process is running, the GC wont clean up the open block devices. Once the metadata process ends, then GC seems to close the devices properly so its kind of difficult to trigger this in a normal way.
We only found about this becuase we were running the metadata in the brackground and our installer was creating new partition tables at the exact same time. If you run the installer sooner you wont hit it, or a bit later and also wont hit it.

- Description for the changelog

Bump go-diskfs to latest and adapt provider_cdrom to the go-diskfs changes.

- A picture of a cute animal (not mandatory but encouraged)
pisco

Also fix cdrom provider use of the new diskfs

Signed-off-by: Itxaka <itxaka@spectrocloud.com>
@Itxaka
Copy link
Contributor Author

Itxaka commented Jan 23, 2023

cc @deitch ;)

@deitch deitch merged commit ea6268d into linuxkit:master Jan 23, 2023
@Itxaka Itxaka deleted the bump_diskfs branch January 23, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants