Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Bump go-diskfs in the metadata.
Fix the provider_cdrom to use the new Open method of diskfs
- How I did it
go get -u github.com/diskfs/go-diskfs@master && go mod vendor
Crazy I know, sometimes my genius… it's almost frightening :p
- How to verify it
Run metadata in the background with the full list of providers so the block devices are opened to get the size, then try to do something on those block devices, like create a new partition table. It will complain that the kernel cannot be informed of the changes to the block device due it being in use by something else.
Problem was mainly that if you run the metadata will the full list of providers and no metadata, it will take a while for all those providers to time out. So while the metadata process is running, the GC wont clean up the open block devices. Once the metadata process ends, then GC seems to close the devices properly so its kind of difficult to trigger this in a normal way.
We only found about this becuase we were running the metadata in the brackground and our installer was creating new partition tables at the exact same time. If you run the installer sooner you wont hit it, or a bit later and also wont hit it.
- Description for the changelog
Bump go-diskfs to latest and adapt provider_cdrom to the go-diskfs changes.
- A picture of a cute animal (not mandatory but encouraged)