Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running git command 254 times #3915

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 23, 2023

Make sure those git commands run only once and not 254 times in total.

Before:

$ make -C kernel -n SHELL="/bin/bash -x" build_5.15.x
+ git rev-parse --show-toplevel
+ uname -m
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse HEAD
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse HEAD
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse HEAD
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse HEAD
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse HEAD
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse HEAD
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
docker pull linuxkit/kernel:5.15.27-c88d1943a797df4fde159a907d5b2ddfd684e5ae-arm64 || docker build --build-arg KERNEL_VERSION=5.15.27 --build-arg KERNEL_SERIES=5.15.x --build-arg EXTRA= --build-arg DEBUG= --build-arg BUILD_IMAGE=linuxkit/alpine:2be490394653b7967c250e86fd42cef88de428ba --label org.opencontainers.image.source=https://github.com/linuxkit/linuxkit --label org.opencontainers.image.revision=c79558cc5a642ff6b8c39866fe15814e568759c1 --label org.mobyproject.linuxkit.kernel.buildimage=linuxkit/alpine:2be490394653b7967c250e86fd42cef88de428ba --no-cache -t linuxkit/kernel:5.15.27-c88d1943a797df4fde159a907d5b2ddfd684e5ae-arm64 .

After:

make -C kernel -n SHELL="/bin/bash -x" build_5.15.x
+ git ls-tree --full-tree HEAD -- /Users/dgageot/src/linuxkit/kernel
+ awk '{print $3}'
+ git update-index -q --refresh
+ git diff-index --quiet HEAD -- /Users/dgageot/src/linuxkit/kernel
+ git rev-parse --show-toplevel
+ uname -m
+ git rev-parse HEAD
+ git rev-parse HEAD
+ git rev-parse HEAD
+ git rev-parse HEAD
+ git rev-parse HEAD
+ git rev-parse HEAD
docker pull linuxkit/kernel:5.15.27-d6fc9337526f0f2f8a64ee150fe4fb9c511f886a-arm64 || docker build --build-arg KERNEL_VERSION=5.15.27 --build-arg KERNEL_SERIES=5.15.x --build-arg EXTRA= --build-arg DEBUG= --build-arg BUILD_IMAGE=linuxkit/alpine:2be490394653b7967c250e86fd42cef88de428ba --label org.opencontainers.image.source=https://github.com/linuxkit/linuxkit --label org.opencontainers.image.revision=f39c638c43bd66d7f0efd70783942ede1c557bf8 --label org.mobyproject.linuxkit.kernel.buildimage=linuxkit/alpine:2be490394653b7967c250e86fd42cef88de428ba --no-cache -t linuxkit/kernel:5.15.27-d6fc9337526f0f2f8a64ee150fe4fb9c511f886a-arm64 .

Signed-off-by: David Gageot <david.gageot@docker.com>
@deitch
Copy link
Collaborator

deitch commented Mar 23, 2023

I don't get it. How was it called 254 times, and how does this help?

@dgageot
Copy link
Contributor Author

dgageot commented Mar 23, 2023

I don't get it. How was it called 254 times, and how does this help?

I've added information to explain the before/after situation.
Basically, I added memoization to prevent such variable to be evaluated every time one of the multiple targets uses it.

@deitch
Copy link
Collaborator

deitch commented Mar 23, 2023

That is the output, thanks. But I still don't understand why this changes. I cannot see why it is called 254 times in the first place.

@dgageot
Copy link
Contributor Author

dgageot commented Mar 23, 2023

make -C kernel -n SHELL="/bin/bash -x" build_5.15.x

This happens because the Makefile uses a template (kernel) to generate the build targets.

@dgageot
Copy link
Contributor Author

dgageot commented Mar 23, 2023

make -C kernel -n SHELL="/bin/bash -x" build_5.15.x

This happens because the Makefile uses a template (kernel) to generate the build targets.

What also doesn't help is that $(TAG) is used all over the place. Without memoization, its value being $(HASH)$(DIRTY), it generates two executions of git each time it's evaluated.

@deitch
Copy link
Collaborator

deitch commented Mar 23, 2023

Ah, right! this here:

define kernel

Now I remember. Also that I struggled with it.

@deitch deitch merged commit eb81457 into linuxkit:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants