include source repo, revision and go package version as build-args #3932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added some fixed default build-args that
linuxkit pkg build
passes to the docker build. These areSOURCE
REVISION
GOPKGVERSION
They are in the docs as well.
These are set only if the user does not override them in
build.yaml
.Also added a test, of course.
Note that I picked build-args that are tied to the filesystem and commit. Thus, they do not interfere with reproducible builds.
I did consider adding the username and host that built, but wasn't sure if that violated our "reproducible always" requirement.
- How I did it
Changes to
git.go
andbuild.go
- How to verify it
CI. I added tests. And I tested manually.
- Description for the changelog
Pass build-context information to package builds via
--builg-arg
- Note
I have a follow on for several packages to take advantage of this.