replace complex manifest-tool with straight go-containerregistry #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
ggcr-for-manifest
branch
from
f8fb905
to
1b22e6f
Compare
justincormack
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
We have a
PushManifest()function, which finds all appropriate arch-specific images in the registry and ensures they are in the multi-arch index. This function was a wrapper around manifest-tool, which itself usescontainerd/remote. It was having authentication issues and was complex to debug, not to mention that it depended on pulling in containerd dependencies.Replaced it with straight go-containerregistry, which we use anyways.
The final binary is a bit smaller, maybe 600K, but the key is that it works better, and if it has issues, it is far easier to debug.
- How I did it
Rewrote
PushManifest().- How to verify it
CI. And of course I ran tests.
- Description for the changelog
Simpler index to registry implementation