logread should not panic on an EOF, instead exiting gracefully #3937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
logread
(inpkg/memlogd
) has an option to-f
and follow. If not, then it reads until the end of the stream and exits.Except it does not exit, it
panic()
, even if it is getting anEOF
.This changes it to exit sanely if it receives an
EOF
- How I did it
Changed lines in
pkg/memlogd/cmd/logread/main.go
- How to verify it
CI, and I did some manual testing. Beforehand, I got:
After, it just exits cleanly
- Description for the changelog
Exit cleanly for logread when EOF