push sboms as well #3957
Merged
push sboms as well #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This is a follow-up to #3954 ; that added sbom support to
lkt pkg buildandlkt build, but missed it forlkt pkg push. When it rebuilds and validates the index in the remote registry, it forgets to ensure that it holds onto existing attestations, as well as pushing ones from local cache.This fixes it
- How I did it
Changes to
PushManifest()andBuild()to ensure it keeps them.While I was at it, made the index merging much more robust, by validating each one on the remote, as well as attestations.
- How to verify it
CI does fine, and I tested manually as well on remote registry.
- Description for the changelog
push sboms