Fix image pull with attestations #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
fix-image-pull-with-attestations
branch
from
754e861
to
72c15e4
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
fix-image-pull-with-attestations
branch
4 times, most recently
from
6c1c437
to
6d821c6
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
fix-image-pull-with-attestations
branch
from
6d821c6
to
6e54a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #3961
validate.Image()does not handle layers that are not actual tar+gzip, so in-toto attestations break it. Needed a workaround. Also makes it a lot simpler.- How I did it
Changed source.
- How to verify it
CI is enough.
- Description for the changelog
Handle attestations on pulls better.