Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile in build yml and CLI; tag templates #3986

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Feb 21, 2024

- What I did

Added two build options to lkt pkg build

  • dockerfile can be specified both in build.yaml and as --dockerfile CLI flag
  • added option to override the tag when building or show-tag via --tag <tag>

For the dockerfile specification, this fits perfectly with the linuxkit philosophy. Everything is reproducible as it is files on the disk. The same way you can specify a different build.yml, you can reference the specific dockerfile.

For the tag, we allow lots of flexibility in naming the generated image. This now lets you specify the actual tag, including using templates, e.g. --tag "version2-{{.Hash}}. Right now, only .Hash is supported, but we could add a more things if they fit.

- How I did it

Changes

- How to verify it

I tested manually, and added tests

- Description for the changelog

Dockerfile selection support, tag flexibility

Signed-off-by: Avi Deitcher <avi@deitcher.net>
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch merged commit 72be49c into linuxkit:master Feb 21, 2024
22 checks passed
@deitch deitch deleted the dockerfile-in-build-yml branch February 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant