Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added support for specifying build args to a package build from another file as
--build-arg-file file1
. You can specify multiple files as--build-arg-file file1 --build-arg-file file2 ...
.This allows interesting patterns, like a
build.yaml
that is usable for multiple structures and versions of something (kernel builds are on my mind) while changing some build args.Or if you want to get kernel-specific:
It fits very well with the linuxkit philosophy, as everything still is in files, and can be tracked via VCS.
In theory, I could have achieved the same result by allowing stacking of
build.yml
files, but that is messy to do. Maybe in the future.I added tests, of course.
- How I did it
Writing code. Writing tests. Happy they pass.
- How to verify it
CI
- Description for the changelog
Support for multiple build-args files