Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch kernel builds to linuxkit pkg build for simplicity #3993

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Feb 29, 2024

- What I did

Replace kernel complex Makefile build with simple wrappers around linuxkit pkg build.

With the latest changes to linuxkit, we are able to simplify long Makefile lines with simple commands. This is because linuxkit pkg build and linuxkit pkg push already have all of the logic to handle local and remote buildkit runners, push only if it exists, merging images in a remote index into what we push, etc.

- How I did it

Changes mainly to Makefile and documents. Added build-args files

- How to verify it

I run it and build and the kernel is correct.

- Description for the changelog

Simplified kernel build process

@deitch
Copy link
Collaborator Author

deitch commented Feb 29, 2024

Still testing it, takes a while.

@deitch deitch force-pushed the kernel-build-with-linuxkit branch 4 times, most recently from 321fa5f to 4f28a67 Compare March 1, 2024 14:01
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch force-pushed the kernel-build-with-linuxkit branch from 4f28a67 to 000b6f4 Compare March 2, 2024 19:22
@deitch
Copy link
Collaborator Author

deitch commented Mar 2, 2024

And it works nicely. The internal makefile steps for building and pushing are simplified materially, and take advantage of linuxkit cache and runners and all. Next step will be to use these to add kernel builds and pushes as part of CI.

@deitch deitch merged commit 10e6d57 into linuxkit:master Mar 2, 2024
22 checks passed
@deitch deitch deleted the kernel-build-with-linuxkit branch March 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant