WIP: cleanup idea/topic views #5347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2023-12-cleanup-views
branch
from
c6561ed
to
c2f2772
Compare
goapunk
force-pushed
the
jd-2023-12-cleanup-views
branch
5 times, most recently
from
2396d5b
to
5ecdec5
Compare
goapunk
commented
Dec 6, 2023
| @@ -28,5 +28,6 @@ djangorestframework==3.14.0 | |||
| easy-thumbnails[svg]==2.8.5 | |||
| git+https://github.com/liqd/django-autoslug.git@liqd2212#egg=django-autoslug | |||
| python-dateutil==2.8.2 | |||
| python-magic==0.4.27 | |||
There was a problem hiding this comment.
required in a4 already, so easiest to use it in mb as well
goapunk
force-pushed
the
jd-2023-12-cleanup-views
branch
from
5ecdec5
to
3e26501
Compare
|
wip till we merged the map pr |
goapunk
force-pushed
the
dev
branch
2 times, most recently
from
7bcc2e6
to
2a273f1
Compare
goapunk
force-pushed
the
jd-2023-12-cleanup-views
branch
from
3e26501
to
f2c6127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for a cleanup of all the views we changed to react,they don't need to be ListViews with an associated model and queryset anymore.
Tasks