Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/activities: prepare removal of activities app #5374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Dec 14, 2023

  • migration to delete models
  • delete all files which can already be safely removed

partly fixes #3600

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

- migration to delete models
- delete all files which can already be safely removed

partly fixes #3600
### Removed

- **Breaking Change** prepare the removal of the activities (face2face) app and delete the
associated models and views
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this breaking if there is no activities happened/happening? And reminds me that I don't have an account on mB prod.

Copy link
Contributor Author

@goapunk goapunk Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the app but as we are open source someone else could ? (not that it is very likely but I thought it would still be nice to mention it as a breaking change)

Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the app from the INSTALLED_APPS too.
And do we include it in the coming release?

@goapunk
Copy link
Contributor Author

goapunk commented Feb 14, 2024

Need to remove the app from the INSTALLED_APPS too. And do we include it in the coming release?

We can include it now I'd say and once it was deployed to prod we can remove it from the INSTALLED_APPS and remove any leftovers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What should happen to the activities app and face2face module?
2 participants