Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix category save issue and bump release #5611

Merged
merged 2 commits into from Apr 23, 2024
Merged

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Apr 23, 2024

Describe your changes
Briefly explain what you did and provide context for a clearer understanding.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk force-pushed the jd-2024-04-fix-category-release branch from ec46a36 to b02b402 Compare April 23, 2024 08:36
@goapunk goapunk changed the title Jd 2024 04 fix category release fix category save issue and bump release Apr 23, 2024
@goapunk goapunk requested a review from m4ra April 23, 2024 08:37
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh there is an error with react-leaflet for the maps

@goapunk
Copy link
Contributor Author

goapunk commented Apr 23, 2024

oh there is an error with react-leaflet for the maps

oh, right, we haven't updated a4 for a while on main :/ will push a fix but I guess we should test this a bit longer

@goapunk goapunk force-pushed the jd-2024-04-fix-category-release branch from b02b402 to b70c4f5 Compare April 23, 2024 08:58
@m4ra
Copy link
Contributor

m4ra commented Apr 23, 2024

@goapunk can you ping the test team then? I am gonna merge this PR now

@m4ra m4ra merged commit 13d26d4 into main Apr 23, 2024
3 checks passed
@m4ra m4ra deleted the jd-2024-04-fix-category-release branch April 23, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants