Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAT-17502] fixed FK #313

Merged
merged 5 commits into from
May 30, 2024
Merged

[DAT-17502] fixed FK #313

merged 5 commits into from
May 30, 2024

Conversation

KushnirykOleh
Copy link
Contributor

@KushnirykOleh KushnirykOleh commented May 13, 2024

just for reference, this functionality should be moved to liquibase-core
liquibase/liquibase#5905

@KushnirykOleh KushnirykOleh changed the title [DAT-17502] fixed FK [DAT-17502] fixed FK ** DO NOT MERGE ** May 13, 2024
@vitaliimak vitaliimak changed the title [DAT-17502] fixed FK ** DO NOT MERGE ** [DAT-17502] fixed FK May 30, 2024
@vitaliimak vitaliimak added the TypeEnhancement TypeEnhancement label May 30, 2024
@vitaliimak vitaliimak changed the base branch from main to DAT-17773-epick May 30, 2024 13:14
.append(") REFERENCES ");
if (referencesString != null) {
if (!referencesString.contains(".") && (database.getDefaultSchemaName() != null) && database
.getOutputDefaultSchema() && (database.supportsSchemas() || database.supportsCatalogs())) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Database.supportsSchemas](1) should be avoided because it has been deprecated.
.append(") REFERENCES ");
if (referencesString != null) {
if (!referencesString.contains(".") && (database.getDefaultSchemaName() != null) && database
.getOutputDefaultSchema() && (database.supportsSchemas() || database.supportsCatalogs())) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Database.supportsCatalogs](1) should be avoided because it has been deprecated.
@vitaliimak
Copy link

I've changed the base branch from main to DAT-17773-epick to simplify testing.

Copy link

sonarcloud bot commented May 30, 2024

@vitaliimak vitaliimak merged commit 467434a into DAT-17773-epick May 30, 2024
10 of 12 checks passed
@vitaliimak vitaliimak deleted the DAT-17502 branch May 30, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeEnhancement TypeEnhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants