added note in drop unique constraint to specify behavior for dropping index along with constraint in oracleDB #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… index along with constraint in oracleDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently were caught off guard by this behavior as we explicitly added drop index after the drop constraint in our changeset and the deployment was failing with index does not exist error, so adding to avoid confusion.
https://github.com/liquibase/liquibase/blob/e605cee3c7795688b2d178a67c5fed818ac52d0e/liquibase-standard/src/main/java/liquibase/sqlgenerator/core/DropUniqueConstraintGenerator.java#L18
Had to read the code at line 40 to confirm and we ended up delivering a non-deploying build to QA internally.
If you would prefer to have the note mentioned in some other format or anything along those lines, please let me know or update according to documentation standards.