fix: input property fingerprinting #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrugger-tgm
force-pushed
the
fix/120-input-property-fingerprint
branch
from
5c5d0f1
to
fb7eb08
Compare
While I can confirm this fixes the issue, I cannot add a test since there is no infrastructure to execute the tasks. ref: liquibase#120
nbrugger-tgm
force-pushed
the
fix/120-input-property-fingerprint
branch
from
acd6e6f
to
6913e71
Compare
|
The next release of the plugin is going to use the Liquibase Command API instead of a JavaExec, so this PR may not be needed anymore. I'm just waiting on a fix in Liquibase, which will hopefully be in the next LB release. |
|
@stevesaliman - the command API fix will be released with Liquibase 4.28.0 on 5/21/2024 (today). Starting with this release, you should be able to re-implement the Gradle plugin to take advantage of the command API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace a "hardcoded/real" property with a gradle style one so gradle can actually use the input as such
Closes: #120