Fix using liquibase in non root project and add some configuration properties #82
Conversation
|
Thank you for your contribution. I'd like to get a better understanding of the technical aspects of the problem. Does this solve a problem where the plugin is applied to a child project, or is it applied by the parent and configured by the child? How does adding 2 task properties solve the problem? How would the two new properties get set to a non-default value? Are there things that would be in build.gradle or the property files? Thanks for any info. |
|
@stevesaliman I have the same problem with liquidbase-gradle-plugin applied in submodule. I tried changes purposed by @chomats and that fixed the problem. It would be nice merge this MR ot to solve multi-module project issue somehow another way, or maybe there is an example how to configure multi-module project ? And I'm just missing something ? Plugin works perfectly with one single project, but after migration to multi-module structure I don't know how to configure it, without removing this one line: |
task luruTagLiquibase(type:org.liquibase.gradle.LiquibaseTask) {
group="liquibase"
workingDir = project.file('.')
useDefaultParentProperties= false
runList="principal"
command = "tag"
requiresValue = true
value= project.ext.luruTagName
}
task luruRollbackLiquibase(type:org.liquibase.gradle.LiquibaseTask) {
group="liquibase"
workingDir = project.file('.')
useDefaultParentProperties= false
runList="principal"
command = "rollback"
requiresValue = true
value= project.ext.luruTagName
}
task tagRollbackLiquibase(type:org.liquibase.gradle.LiquibaseTask) {
group="liquibase"
workingDir = project.file('.')
useDefaultParentProperties= false
runList="principal"
command = "rollback"
requiresValue = true
value= project.rollbacktag
}
|
Hi @chomats, Could you please resolve these merge conflicts? If this fix is still valid with the latest master changes. Thanks, |
|
Hi @chomats, I'm moving this PR to our "In Discussion" project column. Feel free to update the existing merge conflicts when you have a chance so we can move forward with its review. Thanks, |
|
Hi,I have no Time to resolve the merge conflict. The implementation is changed. You can remove my PR. Thanks. Stéphane Chomat Le 24 oct. 2023 à 17:07, Daniel Mallorga ***@***.***> a écrit :
Hi @chomats,
I'm moving this PR to our "In Discussion" project column. Feel free to update the existing merge conflicts when you have a chance so we can move forward with its review.
Thanks,
Daniel.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
This PR is being closed at the creator's request. |
I add two properties in LiquibaseTask
By default, the behavior is the same than before