Merge pull request #2359 from liquibase/DAT-8906

[DAT-8906] Added validation errors for SQLite and DB2z databases
liquibase · Jan 19, 2022 · 22963c0 · 22963c0
2 parents a9b2c81 + e5479bf
commit 22963c0
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AddAutoIncrementGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AddAutoIncrementGenerator.java
@@ -22,6 +22,7 @@ public int getPriority() {
     @Override
     public boolean supports(AddAutoIncrementStatement statement, Database database) {
         return (database.supportsAutoIncrement()
+                && !(database instanceof Db2zDatabase)
                 && !(database instanceof DerbyDatabase)
                 && !(database instanceof MSSQLDatabase)
                 && !(database instanceof HsqlDatabase)

diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateProcedureGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateProcedureGenerator.java
@@ -4,7 +4,6 @@
 import liquibase.Scope;
 import liquibase.database.Database;
 import liquibase.database.core.*;
-import liquibase.exception.DatabaseException;
 import liquibase.exception.ValidationErrors;
 import liquibase.executor.Executor;
 import liquibase.executor.ExecutorService;
@@ -20,11 +19,16 @@
 import liquibase.util.SqlParser;
 import liquibase.util.StringClauses;
 import liquibase.util.StringUtil;
-
 import java.util.ArrayList;
 import java.util.List;
 
 public class CreateProcedureGenerator extends AbstractSqlGenerator<CreateProcedureStatement> {
+
+    @Override
+    public boolean supports(CreateProcedureStatement statement, Database database) {
+        return !(database instanceof SQLiteDatabase);
+    }
+
     @Override
     public ValidationErrors validate(CreateProcedureStatement statement, Database database, SqlGeneratorChain sqlGeneratorChain) {
         ValidationErrors validationErrors = new ValidationErrors();

diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/DropProcedureGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/DropProcedureGenerator.java
@@ -2,6 +2,7 @@
 
 import liquibase.database.Database;
 import liquibase.database.core.MSSQLDatabase;
+import liquibase.database.core.SQLiteDatabase;
 import liquibase.exception.ValidationErrors;
 import liquibase.sql.Sql;
 import liquibase.sql.UnparsedSql;
@@ -11,6 +12,12 @@
 import liquibase.structure.core.StoredProcedure;
 
 public class DropProcedureGenerator extends AbstractSqlGenerator<DropProcedureStatement> {
+
+    @Override
+    public boolean supports(DropProcedureStatement statement, Database database) {
+        return !(database instanceof SQLiteDatabase);
+    }
+
     @Override
     public ValidationErrors validate(DropProcedureStatement statement, Database database, SqlGeneratorChain sqlGeneratorChain) {
         ValidationErrors validationErrors = new ValidationErrors();

diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/ModifyDataTypeGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/ModifyDataTypeGenerator.java
@@ -17,7 +17,7 @@ public class ModifyDataTypeGenerator extends AbstractSqlGenerator<ModifyDataType
 
     @Override
     public boolean supports(ModifyDataTypeStatement statement, Database database) {
-        if (database instanceof SQLiteDatabase) {
+        if (database instanceof SQLiteDatabase || database instanceof Db2zDatabase) {
             return false;
         }
         return super.supports(statement, database);

diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/RenameSequenceGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/RenameSequenceGenerator.java
@@ -19,7 +19,8 @@ public boolean supports(RenameSequenceStatement statement, Database database) {
             && !(database instanceof FirebirdDatabase)
             && !(database instanceof H2Database)
             && !(database instanceof HsqlDatabase)
-            && !(database instanceof InformixDatabase);
+            && !(database instanceof InformixDatabase)
+            && !(database instanceof SQLiteDatabase);
     }
 
     @Override