Fixes issue with incorrect schema in column exists precondition when checking using a snapshot #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloD12
approved these changes
May 6, 2024
There was a problem hiding this comment.
Hi @mpvvliet,
Thank you for another PR. Your code changes look good I would only do again a little suggestion asking you to do the same little refactor (extracting this piece of code in a getSchema method). Other than that, it looks ok to me.
Thanks,
Daniel.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -90,7 +90,11 @@ | |||
| private void checkUsingSnapshot(Database database, DatabaseChangeLog changeLog) throws PreconditionFailedException, PreconditionErrorException { | |||
| Column example = new Column(); | |||
| if (StringUtil.trimToNull(getTableName()) != null) { | |||
| example.setRelation(new Table().setName(database.correctObjectName(getTableName(), Table.class)).setSchema(new Schema(getCatalogName(), getSchemaName()))); | |||
| String schemaName = getSchemaName(); | |||
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
filipelautert
approved these changes
May 9, 2024
rberezen
approved these changes
May 9, 2024
…checking using a snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5666
Impact
Description
When checking for existence of a column using a snapshot, the schema is incorrectly included, leading to an SQL query with a
nullschema. Included code to explicitly use the database default schema if none is set in the precondition.Tested this on MySQL.
Things to be aware of
Things to worry about
Additional Context