Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with incorrect schema in column exists precondition when checking using a snapshot #5795

Merged
merged 1 commit into from
May 10, 2024
Merged

Fixes issue with incorrect schema in column exists precondition when checking using a snapshot #5795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion liquibase-standard/src/main/java/liquibase/precondition/core/ColumnExistsPrecondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@
private void checkUsingSnapshot(Database database, DatabaseChangeLog changeLog) throws PreconditionFailedException, PreconditionErrorException {
Column example = new Column();
if (StringUtil.trimToNull(getTableName()) != null) {
example.setRelation(new Table().setName(database.correctObjectName(getTableName(), Table.class)).setSchema(new Schema(getCatalogName(), getSchemaName())));
String schemaName = getSchemaName();

Check notice

Code scanning / CodeQL

Possible confusion of local and field Note

Confusing name: method
checkUsingSnapshot
also refers to field
schemaName
(without qualifying it with 'this').
if (schemaName == null) {
schemaName = database.getDefaultSchemaName();
}
example.setRelation(new Table().setName(database.correctObjectName(getTableName(), Table.class)).setSchema(new Schema(getCatalogName(), schemaName)));
}
example.setName(database.correctObjectName(getColumnName(), Column.class));

Expand Down