-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for \u2116 symbol win1251 cyrillic symbol of number #1324
Conversation
Add \u2116 symbol That is cyrillic number symbol
Thanks @Stuchalin for your pull request! Here’s what happens next: A member of the Liquibase team will take a look at your contribution and may suggest:
The PR will be prioritized according to our internal development and testing capacity. We’ll let you know when it’s ready to move to the next step or if any changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and test results:
Things to be aware of:
- Change makes sense
- No need for a test since we don't test every letter in the list
Things to worry about:
- Nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix adds \u2116 to the SimpleSqlGrammar list to allow JavaCC to correctly parse the character.
- No additional testing required.
APPROVED
Add \u2116 symbol
That is cyrillic number symbol
name: Pull Request FIX https://liquibase.jira.com/browse/CORE-3326
about: this PR fixes bug https://liquibase.jira.com/browse/CORE-3326 Lexical error at line 5, column 16. Encountered: "\u2116" (8470), after : "". "\u2116" is a win1251 cyrillic symbol of number (https://liquibase.jira.com/browse/CORE-3326)
title: 'CORE-3326 - Lexical error at line 5, column 16. Encountered: "\u2116" (8470), after : ""'
labels: Status:Discovery
assignees: ''
Environment
Liquibase Version: 3.5.5, 3.6.0, 3.6.1, 3.6.2, 4.0.1
Liquibase Integration & Version: maven
Liquibase Extension(s) & Version: -
Database Vendor & Version: Oracle 10g
Operating System Type & Version: macOS, Windows 10
Pull Request Type
Description
https://liquibase.jira.com/browse/CORE-3326
Fast Track PR Acceptance Checklist: