Firebird: fix createIndex missing space around "computed"

[Markus-Patt]

This change fixes the case in invalid sql is generated, when an index with an computed value is created.

---

name: CreateIndexGeneratorFirebird generates invalid SQL on computed field

about: #1490
title: ''
labels: Status:Discovery
assignees: ''

---

Environment

Liquibase Version:
4.1.1

Database Vendor & Version:
Firebird 2.5
Firebird 3.0

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed.

• Adding an index on a "computed by" value generates invalid sql

Steps To Reproduce

    <changeSet id="1" author="1">
        <createTable tableName="foo">
            <column name="id" type="INT">
                <constraints nullable="false" primaryKey="true" primaryKeyName="PK_foo" />
            </column>
            <column name="bar" type="INT" />
        </createTable>
    </changeSet>

    <changeSet id="2" author="2">
        <createIndex tableName="foo" indexName="idx_bar">
            <column name="bar + 1" computed="true" />
        </createIndex>
    </changeSet>

This creates the following sql:

CREATE INDEX idx_baz ON fooCOMPUTED BY (baz + 1)

which misses a space between the table name an the the keyword "computed"

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Documentation Updated

Need Help?

Come chat with us on our discord channel

[molivasdat]

Thanks @Markus-Patt for finding the issue and creating a fix for it.

[Markus-Patt]

Shame on me, I missed a test.
Fixed now.

[github-actions]

Unit Test Results

  4 632 files  +12    4 632 suites  +12   47m 38s ⏱️ + 10m 11s
  4 618 tests +  1    4 399 ✔️ +  1     219 💤 ±0  0 ❌ ±0 
54 588 runs  +12  49 564 ✔️ +12  5 024 💤 ±0  0 ❌ ±0 

Results for commit 874eb54. ± Comparison against base commit e742a88.

♻️ This comment has been updated with latest results.

[nvoxland]

Code review and test results:

Things to be aware of:

• Changes make sense to me
• Only impacts firebird

Things to worry about:

• Nothing

[XDelphiGrl]

Fix addresses a bug in the generation of SQL for Firebird computed indexes.

• New unit test added.
• No additional testing required.

APPROVED

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.