Addition of liquibase.update() Enhancement Request #1614

[Betlista]

Added .update()

• some JavaDocs.

Environment

Liquibase Version: 4.3.0

Liquibase Integration & Version: maven

Liquibase Extension(s) & Version: N/A

Database Vendor & Version: N/A

Operating System Type & Version: Win 10

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality) closes Addition of liquibase.update() #1614
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Described in issue itself.

Steps To Reproduce

Described in issue itself.

Actual Behavior

Described in issue itself.

Expected/Desired Behavior

Described in issue itself.

Screenshots (if appropriate)

N/A

Additional Context

N/A

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us on our discord channel

[molivasdat]

Hi @Betlista
Thanks for providing this PR.

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration) and/or Test Harness Tests
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[nvoxland]

Thanks for the changes, @Betlista

I hadn't originally had the no-arg update() in order to force people to be thinking about context/label usage. But, that's probably an unneeded force to think about and adding the extra function is good. The extra javadocs are good as well.

Code review and test results:

Things to be aware of:

• Adds a method we are not using, only 3rd party code
• Failure in test-harness is not related to change

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 644 files  ±  0    4 644 suites  ±0   33m 43s ⏱️ - 2m 42s
  4 627 tests +  1    4 412 ✔️ +  5     215 💤  - 4  0 ❌ ±0 
54 696 runs  +12  49 676 ✔️ +16  5 020 💤  - 4  0 ❌ ±0 

Results for commit b9d2a37. ± Comparison against base commit 165c594.

♻️ This comment has been updated with latest results.

[XDelphiGrl]

Fix allows integrations to call liquibase update without requiring contexts and/or labels.

• Adds Java docs to several methods.
• Removes duplicated logUnsupportedDatabase method from SnapshotCommandStep.java, calling the method from InternalSnapshotCommand.java instead.
• Tests extended to validate communication with Hub using an update that does not pass contexts and/or labels.
• No additional testing required.

APPROVED

Note: Test failure in harness related to environment setup failure; not related to this change.

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.