Fixed issue with h2 loadUpdateData not correctly handling values with the string " values " in the inserted data

[tomyy]

Environment

Liquibase Version: all

Liquibase Integration & Version: all

Liquibase Extension(s) & Version:

Database Vendor & Version: H2

Operating System Type & Version: all

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.) closes Liquibase loadUpdateData doesn't properly insert H2 column text 'scale values mean' #1767
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

(Copied from #1767)

Here is the description with a workaround:
https://forum.liquibase.org/t/cant-insert-the-string-scale-values-mean-without-it-being-changed/5121

Steps To Reproduce

• Have Liquibase installed in the commandline (latest is fine, 4.3 as of this issue)
• git clone: https://github.com/MAYarbrough/LiquibaseH2Issue
• do a liquibase update SQL

Actual Behavior

Changeset rendered:
-- Changeset db.changelog-master.yaml::1595012255439-41::myarbrou
-- WARNING The following SQL may change each run and therefore is possibly incorrect and/or invalid:
MERGE INTO PUBLIC.usage_agreement_terms (version, text, start_date) VALUES ('v1.0', 'scale KEY(version) values mean', '2021-02-12');

Expected/Desired Behavior

Changeset should be:
-- Changeset db.changelog-master.yaml::1595012255439-41::myarbrou
-- WARNING The following SQL may change each run and therefore is possibly incorrect and/or invalid:
MERGE INTO PUBLIC.usage_agreement_terms (version, text, start_date) KEY(version) VALUES ('v1.0', 'scale values mean', '2021-02-12');

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us on our discord channel

[molivasdat]

Hi @tomyy
Thanks for this PR.
There should be a snapshot build in github actions associated with this PR if the tests succeed.
Here's what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration) and/or Test Harness Tests
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[tomyy]

How can I trigger a rebuild? The "Build and Test / Java 11" failed because some dependencies could not be resolved, but my code change doesn't change any dependencies...

[nvoxland]

Code review and test results:

Things to be aware of:

• Change fixes regular expression to use the first " values " it finds in a statement as the "values" part of the SQL vs. the last " values " it finds which might be in some of the inserted data.
• Adds a unit test for a problem "values" statement
• Only impacts H2

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   36m 32s ⏱️ + 1m 0s
  4 620 tests +  1    4 405 ✔️ +  1     215 💤 ±0  0 ❌ ±0 
54 612 runs  +12  49 592 ✔️ +12  5 020 💤 ±0  0 ❌ ±0 

Results for commit 86fa083. ± Comparison against base commit 4f7e725.

[XDelphiGrl]

PR fixes and H2 bug caused by having the key word "values" in the data of a loadData changetype.

• New unit test added to validate the fix.

APPROVED

Note: There were test harness failures for EDB Postgres; these are unrelated to this fix and were due to the EDB environment not loading correctly.

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.