Tidy ExecutorService code, remove superfluous map access (Issue 1841)

[jamey-clari]

Description

Tidy ExecutorService code, remove superfluous imports and map access.

[molivasdat]

Hi @jamey-clari
If the build succeeds in GitHub Actions there will be a snapshot build of this PR.

Here's what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration) and/or Test Harness Tests
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[jamey-clari]

Hi @jamey-clari
If the build succeeds in GitHub Actions there will be a snapshot build of this PR.

Here's what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration) and/or Test Harness Tests
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

NP @molivasdat - I'd expect things to wind their way through the pipeline for a bit.

[jamey-clari]

It looks like some sort of surefire test failed for only Java 11. It's hard to imagine that any of my edits were JDK version sensitive let alone to version 11 but not 8 and 16. Is it possible the build had some sort of transient issue and simply needs to be retried?

[nvoxland]

Code review and test results:

Things to be aware of:

• The changes make sense, mainly cleanup work
• No change in behavior, so existing tests should would anything changed

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   43m 27s ⏱️ + 6m 17s
  4 617 tests ±0    4 402 ✔️ +4     215 💤  - 4  0 ❌ ±0 
54 576 runs  ±0  49 556 ✔️ +4  5 020 💤  - 4  0 ❌ ±0 

Results for commit c15cc05. ± Comparison against base commit e742a88.

[XDelphiGrl]

• PR makes the code in ExecutorService and AbstractJdbcDatabase classes more readable.
• Fix prevents duplication of stack trace in log output.
• No additional testing required.

APPROVED