-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Derby reserved words #1971
Update Derby reserved words #1971
Conversation
Updated DerbyDatabase definition to use the set of keywords defined in https://db.apache.org/derby/docs/10.2/ref/rrefkeywords29722.html resolves liquibase#1031
Hi @andrewhj Thanks for creating this PR. A member of the Liquibase team will take a look at your contribution and may suggest:
The PR will be prioritized according to our internal development and testing capacity. We’ll let you know when it’s ready to move to the next step or if any changes are needed. |
Code review and test results: Things to be aware of:
Things to worry about:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- PR introduces a revised list of Derby reserved keywords used by Liquibase to determine quoting of generated Derby SQL.
- Source of keywords is the Derby Documentation.
- Existing tests updated to reflect changes in keyword quoting.
- No additional testing required.
APPROVED
Environment
Liquibase Version: master
Liquibase Integration & Version: spring boot
Liquibase Extension(s) & Version:
Database Vendor & Version: Derby
Operating System Type & Version: Windows 10
Pull Request Type
Description
Updated DerbyDatabase definition to use the set of keywords defined in
https://db.apache.org/derby/docs/10.2/ref/rrefkeywords29722.html
Fixes #1031
Steps To Reproduce
define a changeset using a reserved word from the SQL-92 spec (such as action or state)
generate sql or migrate
table name should be standard but in this case would be "quoted"
the VerifyChangeClassesTest and modified derby.sql (included in the PR) perfectly illustrates the change.
Actual Behavior
generates sql like the following:
Expected/Desired Behavior
it should generate sql like:
which should make sql statements less picky about case, which will also make it work better with tools like JPA or DBUnit.