Improve dropAllForeignKeyConstraints performance

[Spindl]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• [] Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

The dropAllForeignKeyConstraints change performs poorly for bigger database schemas in PostgreSQL databases, because more or less the complete schema metadata is loaded for finding the names of the foreign key constraints of a single table. Control was create but wasn't used.

Fixes #2154
Fixes #1571

Things to be aware of

• Test coverage on DropAllForeignKeyConstraintsChangeTest .

Things to worry about

• none

[molivasdat]

Hi @Spindl Thanks for the issue and PR creation. We will add this to the list of issues and PRs that we are processing.
A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration) and/or Test Harness Tests
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[github-actions]

Unit Test Results

  4 668 files  ±0    4 668 suites  ±0   29m 15s ⏱️ - 4m 23s
  4 645 tests ±0    4 419 ✔️ ±0     226 💤 ±0  0 ❌ ±0 
54 744 runs  ±0  49 625 ✔️ ±0  5 119 💤 ±0  0 ❌ ±0 

Results for commit 1518214. ± Comparison against base commit 0f1cb97.

♻️ This comment has been updated with latest results.

[filipelautert]

Hi @Spindl - so from what I see this fall under the "bug fix" section right? Control was create but wasn't used.
Also about #1571, seems it is the same issue. So we can add mark it as fixing this one too.
I did some runs with your text data and it really speeds up things:

Original:
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 489ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 523ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 451ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 467ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 470ms
 
 
 Fix:
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 278ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 303ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 252ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 228ms
 db.foreignKeyDeletionTest.xml::dropTestForeignKeysSlow-1634818754::rsp ran successfully in 241ms

Also there is test coverage on DropAllForeignKeyConstraintsChangeTest .

Thanks!

[filipelautert]

Simple fix that improves performance as shown in my previous comment. Also there are test covering it.

[XDelphiGrl]

This PR fixes a Postgres performance bug during foreign key drops. The fix sets a snapshotControl objects to ensure the entire schema metadata is not scanned to find matching foreign keys.

• No additional testing required.

APPROVED