Improved message when precondition onFail : MARK_RAN is set

[MultiM25]

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Changing the code :

log.info("Marking ChangeSet: " + toString() + " ran despite precondition failure due to onFail='MARK_RAN': " + message);

to

log.info("Marking ChangeSet \"" + toString() + "\" as ran despite precondition failure due to onFail='MARK_RAN': " + message);

Steps To Reproduce

Use this fragment:

databaseChangeLog:
  - changeSet:
      id: 1
      author: dev
      comment: Provoke misunderstandable message being logged
      preConditions:
        - onFail: MARK_RAN
        - onError: HALT
        - tableExists:
            - tableName: NONEXISTENT_TABLE

Actual Behavior

Log message reads like change set was executed ("ran") instead of just marked as "ran" on failure of precondition with on-failure setting MARK_RAN

Expected/Desired Behavior

Log message makes clear that change set was only marked as "ran" but not executed on failure of precondition because of on-failure setting MARK_RAN.

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us on our discord channel

[nvoxland]

Code review and test results:

Things to be aware of:

• Just updates the log message

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 620 files    4 620 suites   39m 40s ⏱️
  4 619 tests   4 404 ✔️    215 💤 0 ❌
54 600 runs  49 580 ✔️ 5 020 💤 0 ❌

Results for commit 304f686.

[XDelphiGrl]

Fix tweaks the message output by a MARK_RAN precondition to make it easier to understand that the change was only marked as run, and not actually run.

APPROVED

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.