Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle old "liquibase tagExists myTag" style CLI structure #2269

Merged
merged 1 commit into from Jan 10, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Dec 13, 2021

Description

fixes #2109


Dev Handoff Notes (Internal Use)

Links

Testing

Dev Verification

Ran liquibase tagExists myTag against an h2 database and got "The tag 'myTag' does NOT exist in '@jdbc:h2:mem:liquibase'" as expected.

Test Requirements (Liquibase Internal QA)

Setup

Execute an update command with attached changelog file

  • liquibase update --changelog-file lb2192-changelog.xml
  • Verify that update was executed successfully

Execute tag command

  • liquibase tag create
  • Verify that tag create was successfully assigned to last row in DATABASECHANGELOG table

Manual Tests

Verify that new CLI command tag-exists --tag works correctly when specified tag is present.

  • liquibase tag-exists --tag create
  • The tag 'create' already exists in <your database> message is shown

Verify that new CLI command tag-exists --tag works correctly when specified tag is not present.

  • liquibase tag-exists --tag mytag
  • The tag 'mytag' does NOT exist in <your database> message is shown

Verify that new CLI command tag-exists works correctly when specified tag is present.

  • liquibase tag-exists create
  • The tag 'create' already exists in <your database> message is shown

Verify that new CLI command tag-exists works correctly when specified tag is not present.

  • liquibase tag-exists mytag
  • The tag 'mytag' does NOT exist in <your database> message is shown

Verify that old CLI command tagExists works correctly when specified tag is present.

  • liquibase tagExists create
  • The tag 'create' already exists in <your database> message is shown

Verify that old CLI command tagExists works correctly when specified tag is not present.

  • liquibase tagExists mytag
  • The tag 'mytag' does NOT exist in <your database> message is shown

Automated Tests

No new functional tests required for this fix.

┆Issue is synchronized with this Jira Bug by Unito

@nvoxland nvoxland added this to To Do in Conditioning++ via automation Dec 13, 2021
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Dec 13, 2021
@nvoxland nvoxland moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Dec 20, 2021
@nvoxland nvoxland merged commit 61da97e into master Jan 10, 2022
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Jan 10, 2022
@nvoxland nvoxland deleted the fix-legacy-tagexists-cli branch January 10, 2022 23:04
@nvoxland nvoxland removed this from Done in Conditioning++ Jan 21, 2022
@nvoxland nvoxland added this to the v4.7.1 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liquibase tagExists command fails if --tag command argument is not used in v4.4.x
4 participants