Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle cacheSize in mariadb #2270

Merged
merged 4 commits into from Jan 10, 2022
Merged

Correctly handle cacheSize in mariadb #2270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d04d4b
Correctly handle cacheSize for mariadb
nvoxland Dec 13, 2021
5a849ef
Correctly handle cacheSize for mariadb
nvoxland Dec 13, 2021
448ac3a
Merge branch 'master' into fix-mariadb-cache-size
nvoxland Jan 3, 2022
4c93822
Handle cacheSize=0 for createSequence on mariadb
nvoxland Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java
View file
Open in desktop
Expand Up @@ -72,7 +72,7 @@ public Sql[] generateSql(AlterSequenceStatement statement, Database database, Sq
}
}

if ((statement.getCacheSize() != null) && (database instanceof OracleDatabase || database instanceof PostgresDatabase)) {
if ((statement.getCacheSize() != null) && (database instanceof OracleDatabase || database instanceof PostgresDatabase || database instanceof MariaDBDatabase)) {
if (statement.getCacheSize().equals(BigInteger.ZERO)) {
buffer.append(" NOCACHE ");
} else {
Expand Down
4 changes: 3 additions & 1 deletion liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java
View file
Open in desktop
Expand Up @@ -92,10 +92,12 @@ public Sql[] generateSql(CreateSequenceStatement statement, Database database, S
}

if (statement.getCacheSize() != null) {
if (database instanceof OracleDatabase || database instanceof Db2zDatabase || database instanceof PostgresDatabase) {
if (database instanceof OracleDatabase || database instanceof Db2zDatabase || database instanceof PostgresDatabase || database instanceof MariaDBDatabase) {
if (BigInteger.ZERO.equals(statement.getCacheSize())) {
if (database instanceof OracleDatabase) {
queryStringBuilder.append(" NOCACHE ");
} else if (database instanceof MariaDBDatabase) {
queryStringBuilder.append(" CACHE 0");
}
} else {
queryStringBuilder.append(" CACHE ").append(statement.getCacheSize());
Expand Down