Enable property parsing in FormattedSqlChangeParser DAT-4793 #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMassaro
approved these changes
Jan 6, 2022
| for (int i = 1; i <= propertyPatternMatcher.groupCount(); i++) { | ||
| String temp = propertyPatternMatcher.group(i); | ||
| String[] parts = temp.split(":"); | ||
| String key = parts[0].trim(); |
There was a problem hiding this comment.
Should you do .toLowerCase() on the key since the regular expression is case insensitive?
There was a problem hiding this comment.
In this case, the container class, ChangeLogParameters does a case-insensitive lookup.
There was a problem hiding this comment.
Right, but if someone types in the key as nAmE for example, the regex would match on it, but this switch statement would not. Unless I'm misunderstanding something. Or perhaps entering nAmE is not valid.
There was a problem hiding this comment.
My bad. I misunderstood which key. You are exactly right.
suryaaki2
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Liquibase Version:
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Liquibase Extension(s) & Version:
Database Vendor & Version:
Operating System Type & Version:
Pull Request Type
Description
A clear and concise description of the issue being addressed. Additional guidance here.
Steps To Reproduce
List the steps to reproduce the behavior.
Actual Behavior
A clear and concise description of what happens in the software before this pull request.
Expected/Desired Behavior
A clear and concise description of what happens in the software after this pull request.
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
Fast Track PR Acceptance Checklist:
Need Help?
Come chat with us on our discord channel