Support non-classpath: protocols in Spring
#2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kataggart
changed the title
nvoxland
approved these changes
May 21, 2022
… reallyinsane-1540
|
The changes make sense to me. I don't have a spring environment set up for testing it with different protocols, but we rely on spring's resource locator this should at least be a step in the right direction even if there are some protocols that have some unfound issues still. |
nvoxland
added
the
SafeToBuild
suryaaki2
approved these changes
May 25, 2022
XDelphiGrl
approved these changes
May 27, 2022
nvoxland
changed the title
classpath: protocols in Spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that SpringResourceAccessor uses classpath* protocol for loading resources if no other protocol is given.
Environment
Liquibase Version:
4.2.0
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
maven
Liquibase Extension(s) & Version:
none
Database Vendor & Version:
none
Operating System Type & Version:
Windows 11
Pull Request Type
Description
A clear and concise description of the issue being addressed. Additional guidance here.
As described in #1540 it is not possible to provide changelogs from outside classpath. All locations will be searched on classpath only, even if a file protocol is provided. File protocol is used when database changelogs are handled outside the running applications as installation procedure is separated from deployment. So providing file protocol should be possible.
Steps To Reproduce
List the steps to reproduce the behavior.
Just specify changelog location with file protocol.
Actual Behavior
Location is changed to point to classpath.
Expected/Desired Behavior
When file protocol is given, this should remain unchanged.
Fast Track PR Acceptance Checklist:
Need Help?