Specify which parameter is missing in the error message

[bendem]

Environment

Liquibase Version: 4.7.1

Liquibase Integration & Version: maven

Liquibase Extension(s) & Version: N/A

Database Vendor & Version: postgresql

Operating System Type & Version: windows 10

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

As seen in a question on stackoverflow, it's kind of unclear that the parameter to use is outputChangeLogFile and not changeLogFile (https://stackoverflow.com/questions/71172130/).

Steps To Reproduce

See SO question.

Actual Behavior

Specify changeLogFile option, get asked to specify changeLogFile option.

Expected/Desired Behavior

Specify changeLogFile option, get asked to specify outputChangeLogFile option.

Screenshots (if appropriate)

N/A

Additional Context

N/A

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us on our discord channel

[nvoxland]

Thanks for the fix! Improving error messages to make life less confusing to users is always great.

I did update the message you suggested slightly to try to simplify it. LMK if you find that less helpful.

Code review and test results:

Things to be aware of

• I didn't run mvn to see the error message, just reviewed the wording change

Things to worry about

• Nothing

[github-actions]

Unit Test Results

  4 524 files  ±0    4 524 suites  ±0   32m 50s ⏱️ ±0s
  4 422 tests ±0    4 204 ✔️  - 4     218 💤 +4  0 ❌ ±0 
52 344 runs  ±0  47 332 ✔️  - 4  5 012 💤 +4  0 ❌ ±0 

Results for commit d6cc7a9. ± Comparison against base commit c1a67a7.

♻️ This comment has been updated with latest results.

[bendem]

Looks good to me. I didn't know if it was named without the output prefix somewhere else so I had left both. Since this is maven specific code, your wording is probably even better

[FBurguer]

It looks like the message is correct now.
[ERROR] Failed to execute goal org.liquibase:liquibase-maven-plugin:4.11.0:generateChangeLog (default-cli) on project LiquiPostgreSQL-app: The output changeLogFile must be specified. -> [Help 1]

Test Environment:
OS: Windows 10
Java 11