Quality Checks for Databases (DAT-9298) #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to caller DAT-9624
Refactored SnapshotCommandStep DAT-9624
DAT-9624
do executeSql in try-with-resources
…ng/unregistering license service
…rectly DAT-9624 (#2684)
Simplify the license checks that occur in the core code Remove ability to store licenses in any other format (like a file) other than a base64 string Move some of the pro license specific code into the pro repo
Add new parameters for QCs for databases to maven plugin.
…03) (#2815) Previously, the maven integration handled its own verification of the pro license key. This meant that specifying the key through the liquibase.properties file was not supported in maven. Now, instead of having maven do the license check, the license checks occur in the command step, and additionally, unneeded license check code from the Main.java class has been removed.
Update 9298 with master
…" property (#2838) (#2839) Add a property called "liquibase.sdk.testSystem.skip" to the test system framework. This property works in conjunction with the "liquibase.sdk.testSystem.test" property, allowing developers to run all test system frameworks, and exclude a subset of them. (cherry picked from commit 8d3abcd)
…2831) Some properties in the property file were not being loaded if they were not specified in their individual mojo definitions.
The existing integration test framework was configured to stop TestSystem's when the cleanup: method was called. Spock internally called this method when it finished executing all of the tests in a class. Thus, when a particular test class was completed, its TestSystem was stopped, which in some cases was premature, since other classes might use the same TestSystem. Instead, the TestSystem's should be stopped when Spock finishes executing all of the tests in all classes. (cherry picked from commit d2bea1a)
Change array to list in TableOutput method Add option to ignore whitespace in CommandTests "contains" comparison
update 9298 with master
update 9298 with master
…9) (#2858) A user could specify their license key using the LIQUIBASE_PRO_LICENSE_KEY property in any provider (perhaps environment variable) and specify a second license key using the LIQUIBASE_LICENSE_KEY property in the defaults file. The defaults file value provider is not registered until after invoking the license service's license installation code, and the license service caches installed licenses so that it does not have to recheck for license keys. However, this means that in the above example, a license specified in the defaults file is not loaded because the license in the environment variable is erroneously installed and cached first.
nvoxland
suggested changes
May 26, 2022
liquibase-core/src/main/java/liquibase/GlobalConfiguration.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/command/AbstractCliWrapperCommandStep.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/command/AbstractDatabaseCommandStep.java
Outdated
Show resolved
Hide resolved
| @@ -62,9 +62,11 @@ public CommandFailedException commandFailed(String message, int exitCode) { | |||
| /** | |||
| * Collects the results and flushes the output stream. | |||
| */ | |||
| CommandResults build() { | |||
| public CommandResults build() { | |||
There was a problem hiding this comment.
Why does this have to become public?
It was designed to not be callable outside the command package because we want the framework to control that portion of the lifecycle. Do we need to open it up like that?
There was a problem hiding this comment.
I refactored the code in SnapshotCommandStep so that it doesn't need to call the build() method. I changed it back to package-protected.
liquibase-core/src/main/java/liquibase/command/CommandScope.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/command/core/SnapshotCommandStep.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/configuration/LiquibaseConfiguration.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/structure/DatabaseObject.java
Outdated
Show resolved
Hide resolved
liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/AbstractLiquibaseMojo.java
Outdated
Show resolved
Hide resolved
suryaaki2
approved these changes
Jun 2, 2022
* change licenseKey mojo property name * undo breaking change to TableOutput API * move buildFullyQualifiedName method to pro code Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com>
nvoxland
suggested changes
Jun 2, 2022
liquibase-cli/src/main/java/liquibase/integration/commandline/LiquibaseCommandLine.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/command/CommandScope.java
Outdated
Show resolved
Hide resolved
nvoxland
approved these changes
Jun 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.