null pointer issue if change changelog object is null

[kamalnigam]

This will throw null pointer if change changelog object is null.
Cannot invoke "liquibase.changelog.DatabaseChangeLog.isIncludeIgnore()" because "changeLog" is null.
Environment Production
Liquibase Version: it started in 3.7.x onward.
public boolean isInheritableIgnore() {
DatabaseChangeLog changeLog = this.getChangeLog();
return changeLog.isIncludeIgnore();
}
This method was added in 3.7.x

Following is the change list
commit 9ae2b57

Liquibase Integration & Version: Spring boot

Liquibase Extension(s) & Version: it started in 3.7.x onward.

Database Vendor & Version: Oracle

Operating System Type & Version: Windows 10

Pull Request Type

Bug fix (non-breaking change which fixes an issue.)
https://forum.liquibase.org/t/null-pointer-exception-in-liquibase-core/6838

Description

when changelog object remain null. this method through null pointer issue.

public boolean isInheritableIgnore() {
DatabaseChangeLog changeLog = this.getChangeLog();
return changeLog.isIncludeIgnore();
}
This method was added in 3.7.x

Cannot invoke "liquibase.changelog.DatabaseChangeLog.isIncludeIgnore()" because "changeLog" is null.

Steps To Reproduce

https://forum.liquibase.org/t/null-pointer-exception-in-liquibase-core/6838

Actual Behavior

Code should no throw null pointer issue

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

[Come chat with us in the Liquibase Forum.](https://forum.liquibase.org/t/null-pointer-exception-in-liquibase-core/6838 Yes, to discuss this.)

[kamalnigam]

Hi @kataggart , when these changes will be reviewed?

[kataggart]

@kamalnigam US is on holiday through Monday. I will raise it in our team stand up on Tuesday. Sorry I can't give you a more firm estimate regarding exactly when the PR will be reviewed. Thanks.

[nvoxland]

Thanks for the fix. The change makes sense, and I added a unit test (and did some minor code reformatting), but I'm not sure how to configure a system to hit the problem. Even from the forum post I could pick out specific repo steps. Could you provide some?

Notes and test results:

Things to be aware of

• Change makes sense and added a unit test, but didn't know what to manually test

Things to worry about

• Nothing

[github-actions]

Unit Test Results

  4 524 files  ±  0    4 524 suites  ±0   29m 18s ⏱️ - 3m 32s
  4 423 tests +  1    4 209 ✔️ +  1     214 💤 ±0  0 ❌ ±0 
52 356 runs  +12  47 348 ✔️ +12  5 008 💤 ±0  0 ❌ ±0 

Results for commit 367dc0e. ± Comparison against base commit c1a67a7.

♻️ This comment has been updated with latest results.

[XDelphiGrl]

Fix is targeted to a specific condition where a changeset does not have a parent changelog. It is unclear what steps to follow to reproduce the issue. However, the fix prevents an NPE and Dev evaluates the change as safe.

• Unit tests added.
• No additional testing necessary.

APPROVED

Test Harness Execution
Functional Test Results
NOTE: Test failures in the functional test suite are due to mismatch in expected console output and actual console output for the checks feature. These are unrelated to the changes in this PR and can be disregarded.