Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split license information into OSS vs. Pro directories #2868

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented May 23, 2022

Description

Currently the licenses directory in the CLI distribution does not break down dependencies between what is used by the OSS code and what is used by the Pro code.

This PR separates the information between new oss and pro subdirectories.

Fixes DAT-10361

Additional Context

The Liquibase Pro EULA license is moved to the pro directory along with the license used by pro dependencies.

@nvoxland nvoxland requested a review from kevin-atx May 23, 2022 15:52
@github-actions
Copy link

github-actions bot commented May 23, 2022

Unit Test Results

  4 524 files  ±0    4 524 suites  ±0   30m 29s ⏱️ - 1m 57s
  4 461 tests ±0    4 247 ✔️ ±0     214 💤 ±0  0 ±0 
52 812 runs  ±0  47 804 ✔️ ±0  5 008 💤 ±0  0 ±0 

Results for commit 0fb9207. ± Comparison against base commit a67e29e.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation May 23, 2022
Copy link
Contributor

@kevin-atx kevin-atx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvoxland - I believe the AGPL license and TrueLicense needs to move to the Pro folder.

Moved AGPL to Pro folder
Reviewed and updated missing or incorrect license text.
Copy link
Contributor

@kevin-atx kevin-atx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved AGPL to Pro folder
Reviewed and updated missing and incorrect license text.

This is correct now from my POV.

@kevin-atx kevin-atx moved this from To Do to Code Review in Conditioning++ May 26, 2022
@nvoxland
Copy link
Contributor Author

The failing functional test is unrelated to this change, so can be ignored.

@nvoxland nvoxland merged commit 0b4a7b3 into master Jun 7, 2022
Conditioning++ automation moved this from Code Review to Done Jun 7, 2022
@nvoxland nvoxland deleted the split-licenses-directories branch June 7, 2022 17:27
@kataggart kataggart added this to the NEXT milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants