Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liquibase.showBanner global configuration setting #2871

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented May 24, 2022

Description

Adds a new liquibase.showBanner setting that disables the Liquibase startup banner. The start time and version information are preserved because they are informational and small.

The default value for the setting is "true".

Fixes #2681

@nvoxland nvoxland added this to To Do in Conditioning++ via automation May 24, 2022
@github-actions
Copy link

Unit Test Results

  4 524 files  +12    4 524 suites  +12   33m 18s ⏱️ - 3m 48s
  4 421 tests +  2    4 203 ✔️  -   2     218 💤 +4  0 ±0 
52 332 runs  +24  47 320 ✔️ +20  5 012 💤 +4  0 ±0 

Results for commit de85dcd. ± Comparison against base commit 0a9d6d8.

@kataggart
Copy link
Contributor

@nvoxland thanks for doing this; please make sure we create a docs PR as well since this is new functionality.

@FBurguer
Copy link

For this pr, i checked the --show-banner setting.
-Setting --show-banner=false does not show the banner PASS
-Setting --show-banner=true shows the banner PASS
-By default, its always on true. PASS

Testing Environment
OS: Windows 10
Java 11

@FBurguer FBurguer self-assigned this May 26, 2022
@nvoxland nvoxland merged commit d44bdb3 into master May 31, 2022
Conditioning++ automation moved this from To Do to Done May 31, 2022
@nvoxland nvoxland deleted the add-nobanner branch May 31, 2022 15:18
@kataggart kataggart added this to the NEXT milestone May 31, 2022
@kataggart kataggart linked an issue Jun 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Community Request: nobanner cli flag for CLI Add option/envvar to disable banner
4 participants