Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added connector-api.jar to internal/lib #2873

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented May 24, 2022

Description

The jaybird.jar we ship requires access to javax.resources which comes with the connector-api.jar.

This adds that required dependency and updates the licenses file accordingly.

Current behavior

Running liquibase update against firebird with an out-of-the-box liquibase configuration fails with a "ClassNotFound" exception

Updated Behavior

Running liquibase update against firebird with an out-of-the-box liquibase configuration runs successfully

@nvoxland
Copy link
Contributor Author

I'm not marking it as autocandidate because the automated test systems manage their own driver dependencies so didn't catch this problem.

@nvoxland nvoxland requested a review from suryaaki2 May 24, 2022 16:50
@nvoxland nvoxland added this to To Do in Conditioning++ via automation May 24, 2022
@github-actions
Copy link

Unit Test Results

  4 512 files    4 512 suites   35m 26s ⏱️
  4 419 tests   4 201 ✔️    218 💤 0
52 308 runs  47 296 ✔️ 5 012 💤 0

Results for commit 4051417.

@FBurguer FBurguer self-assigned this May 25, 2022
@FBurguer
Copy link

FBurguer commented May 26, 2022

liquibase update runs succesfully with an out-of-the-box liquibase configuration. I tried running liquibase without the connector-api.jar and it fails with a javax/resource/ResourceException error, so it is definitly needed for firebird databases.

Testing Environment:
OS: Windows 10
Java 11
Firebird 3.0.7

@nvoxland nvoxland merged commit 5eeb7b0 into master May 31, 2022
Conditioning++ automation moved this from To Do to Done May 31, 2022
@nvoxland nvoxland deleted the add-connector-api-jar branch May 31, 2022 15:17
@kataggart kataggart added this to the NEXT milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants