Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TableOutput spaces when using long words (DAT-10069) #2879

Merged
merged 3 commits into from
May 31, 2022

Conversation

StevenMassaro
Copy link
Contributor

Environment

Liquibase Version: N/A

Liquibase Integration & Version: N/A

Liquibase Extension(s) & Version: N/A

Database Vendor & Version: N/A

Operating System Type & Version: N/A

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Outputting long lines with a single word that spans over multiple lines caused the next word to be appended directly without a space:

+-----+--------------------------------+-----------------------------+--------------------------------+---------+--------------------------------+----------+
| 127 | Disallow postgres non reserved | PostgresNonReservedKeywords | Disallow Postgres non-reserved | false   | OBJECT_TYPES = null            | 0        |
|     | keywords                       |                             | keywords from being used in    |         | ALLOWED_LIST = null            |          |
|     |                                |                             | database object names. See     |         | CASE_SENSITIVE = true          |          |
|     |                                |                             | https://www.postgresql.org/doc |         |                                |          |
|     |                                |                             | s/14/sql-keywords-appendix.htm |         |                                |          |
|     |                                |                             | lfor complete list of keywords |         |                                |          |
|     |                                |                             | .                              |         |                                |          |
+-----+--------------------------------+-----------------------------+--------------------------------+---------+--------------------------------+----------+

Steps To Reproduce

Use the TableOutput class to print out a cell with a single word that stretches over multiple lines.

Actual Behavior

Word after the long word is appended without a space.

Expected/Desired Behavior

Space exists between long word and next word.

Screenshots (if appropriate)

Additional Context

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us in the Liquibase Forum.

@github-actions
Copy link

github-actions bot commented May 25, 2022

Unit Test Results

  4 512 files  ±0    4 512 suites  ±0   34m 23s ⏱️ + 1m 54s
  4 419 tests ±0    4 205 ✔️ +4     214 💤  - 4  0 ±0 
52 308 runs  ±0  47 300 ✔️ +4  5 008 💤  - 4  0 ±0 

Results for commit 8ca2aeb. ± Comparison against base commit 4ab687b.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation May 30, 2022
@StevenMassaro StevenMassaro merged commit a433639 into master May 31, 2022
Conditioning++ automation moved this from To Do to Done May 31, 2022
@StevenMassaro StevenMassaro deleted the DAT-10069 branch May 31, 2022 15:12
Copy link
Contributor

@wwillard7800 wwillard7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants