Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on better Git Bash console solution DAT-10230 #2882

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Conversation

wwillard7800
Copy link
Contributor

Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us in the Liquibase Forum.

@github-actions
Copy link

github-actions bot commented May 26, 2022

Unit Test Results

  4 512 files  ±0    4 512 suites  ±0   35m 49s ⏱️ + 2m 7s
  4 419 tests ±0    4 205 ✔️ +4     214 💤  - 4  0 ±0 
52 308 runs  ±0  47 300 ✔️ +4  5 008 💤  - 4  0 ±0 

Results for commit dd8305c. ± Comparison against base commit 0a9d6d8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine these changes seem right, despite not having fought with how git bash sets itself up :)

@kataggart kataggart added this to To Do in Conditioning++ via automation May 30, 2022
@suryaaki2 suryaaki2 merged commit 4bbefdd into master Jun 10, 2022
Conditioning++ automation moved this from To Do to Done Jun 10, 2022
@suryaaki2 suryaaki2 deleted the DAT-10230 branch June 10, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants