Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote liquibase.jar path in bash launcher #2885

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

nvoxland
Copy link
Contributor

Description

The current liquibase bash script does not quote the liquibase.jar path, so it will not run if there is a space in the path to LIQUIBASE_HOME. It fails with a Error: Unable to access jarfile error.

This quotes the path so it works correctly

Repo Steps

  1. Untar liquibase.tar.gz to a path containing a space in the filename
  2. Run ./liquibase --version

@nvoxland nvoxland requested a review from suryaaki2 May 26, 2022 21:05
@nvoxland nvoxland added this to To Do in Conditioning++ via automation May 26, 2022
@github-actions
Copy link

Unit Test Results

  4 512 files  ±0    4 512 suites  ±0   33m 19s ⏱️ +50s
  4 419 tests ±0    4 205 ✔️ +4     214 💤  - 4  0 ±0 
52 308 runs  ±0  47 300 ✔️ +4  5 008 💤  - 4  0 ±0 

Results for commit 71f0795. ± Comparison against base commit 4ab687b.

@nvoxland
Copy link
Contributor Author

The failing functional test is unrelated to this change, so can be ignored.

@ecarneiro01 ecarneiro01 self-assigned this Jun 1, 2022
@ecarneiro01
Copy link

I confirmed that the command --version can be executed even if there are spaces in the LIQUIBASE_HOME path.

image

@nvoxland nvoxland merged commit c1a67a7 into master Jun 1, 2022
Conditioning++ automation moved this from To Do to Done Jun 1, 2022
@nvoxland nvoxland deleted the fix-liquibase-jar-quoting-in-bash branch June 1, 2022 18:29
@kataggart kataggart added this to the NEXT milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants