-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move opencsv to be non-shaded #2903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
approved these changes
Jun 7, 2022
There is still a liquibase/repackaged dir in liquibase-core.jar, it has nothing to do with opencsv though, so thats fine. |
chadlwilson
added a commit
to chadlwilson/gocd
that referenced
this pull request
Jun 20, 2022
Liquibase 4.12 stopped shading some dependencies, so we can now exclude them properly. It seems our usage does not require these at this stage. https://github.com/liquibase/liquibase/blob/master/changelog.txt and liquibase/liquibase#2903 are relevant here.
grafjo
pushed a commit
to urlaubsverwaltung/urlaubsverwaltung
that referenced
this pull request
Nov 25, 2022
grafjo
pushed a commit
to urlaubsverwaltung/urlaubsverwaltung
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than shading opencsv into the liquibase-core.jar, define it as a dependency in the shipped pom.xml and include it as a separate jar in the internal/lib directory.
Opencsv has dependencies on commons-collections4, commons-lang3, and commons-text so they are will be in the internal/lib directory as well.
Partly addresses #2852 but not fully so not marking it as "fixes"
Expected changes
Testing
The CLI and maven plugin should continue to handle changelogs with loadData pointing to CSV files with no issues.