Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prepared statements for query #2913

Merged
merged 8 commits into from
Jun 14, 2022
Merged

Support prepared statements for query #2913

merged 8 commits into from
Jun 14, 2022

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Jun 3, 2022

No description provided.

fbiville added a commit to liquibase/liquibase-neo4j that referenced this pull request Jun 3, 2022
@fbiville
Use prepared statements based on liquibase/liquibase#2913
b744212
@kataggart kataggart added this to To Do in Conditioning++ via automation Jun 6, 2022
@fbiville fbiville mentioned this pull request Jun 7, 2022
Merged
@fbiville
Copy link
Contributor Author

fbiville commented Jun 7, 2022

This change has been tested end-to-end in liquibase/liquibase-neo4j#195 and it works perfectly!
This would be a SUPER USEFUL addition for the Neo4j plugin.

@kataggart kataggart requested a review from nvoxland June 9, 2022 14:32
@nvoxland nvoxland added this to the NEXT milestone Jun 9, 2022
fbiville added a commit to liquibase/liquibase-neo4j that referenced this pull request Jun 13, 2022
@fbiville
Use prepared statements based on liquibase/liquibase#2913
59cdcba
@nvoxland nvoxland added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jun 14, 2022
@nvoxland nvoxland marked this pull request as ready for review June 14, 2022 17:33
@nvoxland nvoxland changed the base branch from master to 1_9 June 14, 2022 17:34
@nvoxland nvoxland changed the base branch from 1_9 to master June 14, 2022 17:34
@nvoxland nvoxland added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jun 14, 2022
@nvoxland nvoxland requested a review from suryaaki2 June 14, 2022 17:35
@nvoxland nvoxland requested a review from XDelphiGrl June 14, 2022 17:35
@nvoxland
Copy link
Contributor

Code Review and test results:

Things to be aware of

  • I worked with @fbiville on the changes. He tested that it works with his use case
  • Until I get the liquibase-sdk module split out, the change is in a module that I can't write an integration test for
  • It's not code that is used by anything in liquibase-core, but adds a capability usable by extensions (and future liquibase funtionality)

Things to worry about

  • Nothing

XDelphiGrl
XDelphiGrl approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change improves handling of parameterized SQL statements.
  • Code impacts only extension writers.
  • @fbiville and @nvoxland co-ordinated manual testing of the fix in Florent's environment.
    • Thank you for being an amazing Liquibase contributor, @fbiville!

APPROVED

@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited

Unit Test Results

  4 548 files  ±0    4 548 suites  ±0   30m 57s ⏱️ + 1m 4s
  4 508 tests ±0    4 294 ✔️ +4     214 💤  - 4  0 ❌ ±0 
53 376 runs  ±0  48 368 ✔️ +4  5 008 💤  - 4  0 ❌ ±0 

Results for commit b670076. ± Comparison against base commit 9985a44.

♻️ This comment has been updated with latest results.

@nvoxland nvoxland added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jun 14, 2022
@nvoxland nvoxland merged commit 970f63b into liquibase:master Jun 14, 2022
Conditioning++ automation moved this from To Do to Done Jun 14, 2022
@fbiville fbiville deleted the issue_2721 branch June 15, 2022 08:40
fbiville added a commit to liquibase/liquibase-neo4j that referenced this pull request Jun 20, 2022
@fbiville
Use prepared statements based on liquibase/liquibase#2913
95b78f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@XDelphiGrl XDelphiGrl XDelphiGrl approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees
No one assigned
Labels
autocandidate Extensions SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2022-27
Projects
Liquibase Open Source
Archived in project
Conditioning++
Done
Milestone
v4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fbiville @nvoxland @XDelphiGrl @suryaaki2 @kataggart