Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored OSGi headers #2924

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Restored OSGi headers #2924

merged 1 commit into from
Jun 9, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jun 7, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A change to how we configure the final liquibase-core.jar file in the maven build script made the 4.11.0 release not include the Export-Package, Bundle-*, and many other META-INF/MANIFEST.MF settings needed for OSGi.

This undoes the change from 4.11.0 while still preserving the Main-Class attribute it was trying to add

Fixes #2922

Things to be aware of

  • Need to ensure the CLI launcher still works, since the way Main-Class is set has been changed

Things to worry about

  • Nothing

@nvoxland nvoxland added this to To Do in Conditioning++ via automation Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Unit Test Results

  4 524 files  ±0    4 524 suites  ±0   35m 5s ⏱️ + 2m 37s
  4 468 tests ±0    4 250 ✔️  - 4     218 💤 +4  0 ±0 
52 896 runs  ±0  47 884 ✔️  - 4  5 012 💤 +4  0 ±0 

Results for commit a986a91. ± Comparison against base commit 6d1b853.

@FBurguer FBurguer self-assigned this Jun 9, 2022
@FBurguer
Copy link

FBurguer commented Jun 9, 2022

Looks like all the missing config is back on this build.

@nvoxland nvoxland merged commit c60f21a into master Jun 9, 2022
Conditioning++ automation moved this from To Do to Done Jun 9, 2022
@nvoxland nvoxland deleted the restore-osgi-headers branch June 9, 2022 17:59
@kataggart kataggart linked an issue Jun 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

MANIFEST.MF is missing OSGi information since release 4.10 OSGi headers missing from liquibase-core 4.11.0
4 participants