Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snowflake driver to CLI #2931

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Added snowflake driver to CLI #2931

merged 3 commits into from
Jun 9, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jun 8, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Now that we ship snowflake support without needing an extension, we are adding the driver as a shipped dependency to make it easier for everyone using snowflake.

Things to be aware of

  • Adds snowflake-jdbc.jar to internal/lib
  • Should not be adding any additional jar files vs. what was in internal/lib before
  • Version shows in liquibase --version
  • Should now be able to run liquibase against snowflake without having to add anything to the lib dir
  • Also removes the snowflake extension from the extension release list

Things to worry about

  • Nothing

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Unit Test Results

  4 548 files  ±  0    4 548 suites  ±0   30m 21s ⏱️ - 5m 54s
  4 506 tests  - 92    4 288 ✔️  - 96     218 💤 +4  0 ±0 
53 352 runs  ±  0  48 340 ✔️  -   4  5 012 💤 +4  0 ±0 

Results for commit b1a02a8. ± Comparison against base commit 6ba093d.

♻️ This comment has been updated with latest results.

@suryaaki2 suryaaki2 self-requested a review June 8, 2022 18:32
# Conflicts:
#	liquibase-dist/src/main/assembly/assembly-bin.xml
@nvoxland nvoxland added this to the NEXT milestone Jun 9, 2022
@FBurguer FBurguer self-assigned this Jun 9, 2022
@FBurguer
Copy link

FBurguer commented Jun 9, 2022

On this PR, the only new driver in internal/lib dir is snowflake-jdbc.jar. Also it is not in the extention release list anymore.

@nvoxland nvoxland merged commit 5d2681e into master Jun 9, 2022
Conditioning++ automation moved this from To Do to Done Jun 9, 2022
@nvoxland nvoxland deleted the add-snowflake-driver branch June 9, 2022 17:59
@nvoxland nvoxland linked an issue Jun 13, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Snowflake driver to CLI
4 participants